Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Input (1 of 2) #9

Merged
merged 3 commits into from
Aug 7, 2024
Merged

File Input (1 of 2) #9

merged 3 commits into from
Aug 7, 2024

Conversation

calebjacob
Copy link
Collaborator

@calebjacob calebjacob commented Aug 6, 2024

Closes: #1

Unfortunately, we don't currently have a great way of previewing this new component. We have a ticket open to build out a component preview page that should help with this in the future: #6

  • Implement new FileInput component
  • Supports drag and drop
  • Support single vs multiple file selection via multiple boolean prop and limit file types via accept prop
  • Validate all files based on accept, multiple, and maxFileSizeBytes
  • Works well with React Hook Form

Feel free to check out the code and new README file and let me know if you have any suggestions! Once this is merged and published, I'll push another PR to update our ticketing project to use this new component on our /events/new route.

Here are some screenshots:

Screenshot 2024-08-06 at 3 27 18 PM Screenshot 2024-08-06 at 3 27 36 PM Screenshot 2024-08-06 at 3 28 00 PM

@calebjacob calebjacob changed the title File Input File Input (1 of 2) Aug 6, 2024
Copy link

@shelegdmitriy shelegdmitriy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calebjacob calebjacob merged commit a603540 into main Aug 7, 2024
2 checks passed
@calebjacob calebjacob deleted the feat/file-input branch August 7, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Component: <FileSelector />
2 participants